Add working directory option and /home/ubuntu directory validation#3
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
Add working directory option and /home/ubuntu directory validation#3devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: hinoshita1992@gmail.com <hinoshita1992@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
Closing in favor of PR #5 which includes these changes plus additional improvements |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working Directory Option and $HOME Validation
This PR adds:
-w, --working-dir)Implementation Details
getWorkingDir()function to retrieve working directory from CLI options or default to $HOMEisUnderHome()function to validate paths are under the user's home directoryTesting
pnpm buildpnpm testLink to Devin run: https://app.devin.ai/sessions/bd23fbf0492b460f851d2f1f910e60ca
Requested by: hinoshita1992@gmail.com